Skip to content

Adjust KindHasGetConstantValueOverload approach #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 23, 2025

Tinkering with #5517, splitting out this suggestion to try to avoid delaying merge. I figured out what I was missing on the variadiac expansion. :)

(and also realized the struct could probably be a function)

@jonmeow jonmeow requested a review from danakj May 23, 2025 16:34
@github-actions github-actions bot requested a review from geoffromer May 23, 2025 16:35
@jonmeow jonmeow removed the request for review from geoffromer May 23, 2025 16:35
Copy link
Contributor

@danakj danakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice. I don't think I've seen a fold in a {} then before, yay. LGTM

@jonmeow jonmeow enabled auto-merge May 23, 2025 17:48
@jonmeow jonmeow added this pull request to the merge queue May 23, 2025
Merged via the queue into carbon-language:trunk with commit 95ce06a May 23, 2025
8 checks passed
@jonmeow jonmeow deleted the try-eval branch May 23, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants