Try out a different IdKind table approach #5528
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about these after #5526, was wondering how others will feel about this kind of approach:
TypeEnum
to get the table construction.Make
functions, return the element instead of returning the table.I think this is a mild simplification, but maybe worth it.
Note, would appreciate it if there are thoughts on how to provide a boilerplate
Invalid
implementation (maybe it'd be fine to just returnnullptr
and cause a crash that way, but I was hesitant to do that).