Skip to content

Postgresql for Windows #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoramdelangen opened this issue Mar 20, 2025 · 2 comments · Fixed by #665
Closed

Postgresql for Windows #664

yoramdelangen opened this issue Mar 20, 2025 · 2 comments · Fixed by #665
Labels
kind/extension Issues related to extensions os/windows Things only for Windows question Further information is requested

Comments

@yoramdelangen
Copy link
Contributor

yoramdelangen commented Mar 20, 2025

I have added Postgresql support for Windows, it is almost ready for a PR. I used the prebuild binaries provided by EDB. https://www.enterprisedb.com/download-postgresql-binaries

Making the process very simple, but I ran into some questions:

  • There is no license or contribution file in it, and without I receive an error after successfully build/compiling the extension. I could fix it by grabbing it from the Linux/MacOS source..
  • Should I target the latest version of PostgreSQL (version 17.4 instead of 16.8)
  • I use the prebuild binaries from EDB is that allowed to use or should I stick to the source of postgresql.org? edit: on the postgresql.org website they reference for prebuild binaries the EDB website.

Advanced users can also download a zip archive of the binaries, without the installer. This download is intended for users who wish to include Postgres as part of another application installer.

EDIT:
Copied the contents of the COPYRIGHT file into the config/source as text.

@yoramdelangen yoramdelangen added the question Further information is requested label Mar 20, 2025
yoramdelangen added a commit to yoramdelangen/static-php-cli that referenced this issue Mar 20, 2025
@crazywhalecc crazywhalecc added kind/extension Issues related to extensions os/windows Things only for Windows labels Mar 20, 2025
@crazywhalecc
Copy link
Owner

Using official pre-builds is acceptable if you can verify that the source is official or certified and that the pulled binaries work for at least VS2019 and VS2022.

But if the build process is simple (for example, a .sln is provided), I still recommend keeping the complete build process.

@yoramdelangen
Copy link
Contributor Author

Yes, @crazywhalecc I have verified its official. The pulled zip contains all the compiled .lib files.
Documentation-wise the build process is kinda the same as Linux and MacOS, found this way a bit more confient. Maybe a later refactor, depending on what you want?

The PR should be ready to go, but 8.4 is breaking due to having a prefix. Locally compiling for 8.4 works perfectly fine, but in the GH actions it breaks

crazywhalecc added a commit that referenced this issue Mar 24, 2025
* Add pgsql extension for Windows <#664>

* Add pgsql to windows test

* Added pdo_pgsql for windows, added missing header files

* Adjust some configure args and deps

---------

Co-authored-by: crazywhalecc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/extension Issues related to extensions os/windows Things only for Windows question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants