Skip to content

Add pgsql extension for Windows <#664> #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yoramdelangen
Copy link
Contributor

@yoramdelangen yoramdelangen commented Mar 20, 2025

What does this PR do?

Added pgsql and pdo_pgsql extension for Windows. Waiting for answers in #664 before ready. Fix #664

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added new feature New feature or request kind/extension Issues related to extensions os/windows Things only for Windows labels Mar 20, 2025
@yoramdelangen yoramdelangen marked this pull request as ready for review March 21, 2025 15:23
# Conflicts:
#	config/ext.json
#	src/globals/test-extensions.php
@crazywhalecc
Copy link
Owner

Everything looks good to me now. Thanks for your contribution!

@crazywhalecc crazywhalecc merged commit ee54b6d into crazywhalecc:main Mar 24, 2025
12 checks passed
@yoramdelangen yoramdelangen deleted the feat/add-pgsql-for-windows branch March 24, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/extension Issues related to extensions new feature New feature or request os/windows Things only for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgresql for Windows
2 participants