Skip to content

Update Header UI #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
austincondiff opened this issue Feb 14, 2020 · 9 comments
Open
5 tasks

Update Header UI #3263

austincondiff opened this issue Feb 14, 2020 · 9 comments

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Feb 14, 2020

Based on the design in #2557, update the header UI in the project. Feel free to use this CodeSandbox for reference.

  • Change styles to match design
  • Add to Storybook
  • Write tests
  • Ensure tests pass
  • Open a pull request
@tinfoil-knight
Copy link
Contributor

@austincondiff Can I claim this issue?

@austincondiff
Copy link
Collaborator Author

Of course!

@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Jun 4, 2020

@austincondiff I took a look around the CodeSandbox and your thread on UI changes. Do I refer the first image or the second one for making changes to the UI?
Also, can you please assign the issue to me so that I can access it easily from my Github homepage.

82763080-7fb8e600-9dca-11ea-81de-4d5163604dda
63219882-57b49c00-c141-11e9-9f79-9fa7598b19b1

@austincondiff
Copy link
Collaborator Author

The first dark image. The editor header is separate from the app header FYI. The app header will be on the collection pages and the workflow page, but won’t be on the editor page. I will update the issue with the latest mockups.

@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Jun 5, 2020

@austincondiff

  1. Are the React components going to be class based(like they are currently) or functional (as they are in your CodeSandbox)?
  2. What about the Save, Delete unpublished entry, Set status buttons which are currently not in the mockup?
  3. How would Unsaved Changes be depicted?
  4. Would the Publish button change to Published as it does now or will there only be a toast confirmation as in the sandbox?

@austincondiff
Copy link
Collaborator Author

austincondiff commented Jun 5, 2020

  1. Are the React components going to be class based(like they are currently) or functional (as they are in your CodeSandbox)?

Functional with hooks.

  1. What about the Save, Delete unpublished entry, 'Set status` buttons which are currently not in the mockup?

For now, put them in the more menu.

  1. How would Unsaved Changes be depicted?

I will have to think about that and get back to you. We can discuss on Slack and then I will post a final mockup.

  1. Would the Publish button change to Published as it does now or will there only be a toast confirmation as in the sandbox?

The Publish button should say Published and be disabled when it has been published. As soon as the user makes another change though the button should be enabled and say Publish again.

@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Jun 18, 2020

@austincondiff
Sorry for the delay!
The LogoTile from the AppBar has been deleted as discussed on Slack.

For the SearchBar, I looked at previously defined SearchContainer in Collection and MediaLibrary component and tried to create a SearchBar component that can be used everywhere. Take a look and tell me if you have some feedback.

Screen Shot 2020-06-18 at 7 10 16 PM

It uses the renderEnd value to render optional EndContent just like in AppBar.
I'll complete the component with tests and make a PR soon.

@austincondiff
Copy link
Collaborator Author

Looks fantastic. Way to go. Looking forward to the PR! 🚀

@tinfoil-knight
Copy link
Contributor

WIP: #3926

austincondiff pushed a commit that referenced this issue Jun 27, 2020
* fix: remove icon from AppBar

* feat: add SearchBar component
@tinfoil-knight tinfoil-knight removed their assignment Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants