header ui update closes #3263 #3926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@austincondiff Please review the PR and suggest changes if any. |
erezrokah
added
the
type: feature
austincondiff
approved these changes
Jun 27, 2020
| background-color: ${({ theme }) => theme.color.surfaceHighlight}; | ||
| border-radius: 6px; | ||
| font-size: 14px; | ||
| padding: 10px 6px 10px 32px; |
There was a problem hiding this comment.
Use rems here.
padding: 0.625rem 0.375rem 0.625rem 2rem;
| color: ${({ theme }) => theme.color.highEmphasis}; | ||
| background-color: ${({ theme }) => theme.color.surfaceHighlight}; | ||
| border-radius: 6px; | ||
| font-size: 14px; |
There was a problem hiding this comment.
Use rem here
font-size: 0.875rem;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commit 1:
Removes the
LogoTilefrom theAppBarCommit 2:
Adds a
SearchBarcomponent with an optionalrenderEndparameter.The design was inherited from existing
CollectionSearchcomponent and extended.Test plan
Snapshot of the newly added component with
renderEndenabledNote
Some changes on the
AppBarcomponent are pending and will be done soon.