Skip to content

fix(compile): temporarily fallback to reading resource data from file on windows #29024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dsherret
Copy link
Member

Temp hacky fix for #28982

@@ -117,6 +117,118 @@ pub fn extract_standalone(
})
}

fn find_section() -> Result<&'static [u8], AnyError> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Written by AI. Use care reviewing.

@dsherret dsherret changed the title fix(compile): temporarily read resource data from file fix(compile): temporarily fallback to reading resource data from file on windows Apr 23, 2025
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 3d16eb8 into denoland:main Apr 24, 2025
18 checks passed
@dsherret dsherret deleted the fix_compile_windows_file_read_fallback branch April 24, 2025 02:08
dsherret added a commit that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants