Skip to content

fix(compile): use a memory mapped file for fallback #29039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

fix(compile): use a memory mapped file for fallback #29039

merged 4 commits into from
Apr 24, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 24, 2025 •
edited
Loading

#29024 wasn't exactly correct. Let's just use a memory mapped file.

Part of #28982

littledivy
littledivy approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets give this a try

@dsherret dsherret enabled auto-merge (squash) April 24, 2025 16:29
@dsherret dsherret merged commit 2eeccf1 into denoland:main Apr 24, 2025
18 checks passed
@dsherret dsherret deleted the fix_compile_memory_mapped_file_fallback branch April 24, 2025 18:01
dsherret added a commit that referenced this pull request Apr 24, 2025
@dsherret
fix(compile): use a memory mapped file for fallback (#29039)
e1e86bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy littledivy approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @bartlomieju @littledivy