Make mode always u32 and switch to has_mode for StatRes fbs #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Sep 17, 2018
src/flags.rs
Outdated
| @@ -222,7 +221,6 @@ pub fn v8_set_flags(args: Vec<String>) -> Vec<String> { | |||
| let cstr = CStr::from_ptr(*ptr as *const i8); | |||
| let slice = cstr.to_str().unwrap(); | |||
| slice.to_string() | |||
| }) | |||
| .chain(rest.into_iter()) | |||
There was a problem hiding this comment.
@ry They are caused by running formatting. Could revert them manually tho, not quite sure if supposed to
There was a problem hiding this comment.
Reverting them anyways for now
ry
added a commit
to ry/deno
that referenced
this pull request
Sep 22, 2018
- Add atob() btoa() denoland#776 - Add deno.arch deno.platform denoland#773 - Add deno.symlink() and deno.symlinkSync() denoland#742 - Add deno.mkdir() and deno.mkdirSync() denoland#746 - Add deno.makeTempDir() denoland#740 - Improvements to FileInfo interface denoland#765, denoland#761 - Add fetch.blob() - Upgrade V8 to 7.0.276.15 - Upgrade Rust crates
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
intas mode is a mistake (based on Go's FileMode). Switch back touintand useshas_modeto represent non-unix case