Add atob/btoa based on base64-js #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Sep 20, 2018
js/errors.ts
Outdated
| super(msg); | ||
| this.name = "InvalidCharacterError"; | ||
| } | ||
| } |
1 task
hayd
reviewed
Sep 21, 2018
| } | ||
| let result = ""; | ||
| for (let i = 0; i < byteArray.length; i++) { | ||
| result += String.fromCharCode(byteArray[i]); |
There was a problem hiding this comment.
is it better for performance to push to an array and join?
There was a problem hiding this comment.
I actually just saw an interesting benchmark on this, and by running on both Safari and Chrome, it seems for V8 string concat is faster, while JavaScriptCore runs join with better performance. There is a stackoverflow thread that discuss the internals, though it might be dated and not true any more
ry
added a commit
to ry/deno
that referenced
this pull request
Sep 22, 2018
- Add atob() btoa() denoland#776 - Add deno.arch deno.platform denoland#773 - Add deno.symlink() and deno.symlinkSync() denoland#742 - Add deno.mkdir() and deno.mkdirSync() denoland#746 - Add deno.makeTempDir() denoland#740 - Improvements to FileInfo interface denoland#765, denoland#761 - Add fetch.blob() - Upgrade V8 to 7.0.276.15 - Upgrade Rust crates
Merged
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
…and#772)" (denoland#776) This reverts commit 98d52cf. CC @littledivy I had trouble updating `deno_core` in Deno as it died on `node_unit_tests::vm_test` with signal 11 during `vm context promise rejection` test. Also `Box<Rc<...>>` seems fishy as pointed as by @dsherret in denoland/deno_core#775 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #775 . Uses
base64-jsfor implementation (pure JS/TS)There is still another option: use a polyfill version, which might be more lightweighted.