fix(web): OAuth quota size #18526
Open
fix(web): OAuth quota size #18526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuzihao051119
force-pushed
the
fix-oauth-quota-size
branch
from
d9f8695 to
ac9af24
Compare
wuzihao051119
force-pushed
the
fix-oauth-quota-size
branch
from
ac9af24 to
3b88e3a
Compare
github-actions
bot
added
the
documentation
|
📖 Documentation deployed to pr-18526.preview.immich.app |
wuzihao051119
force-pushed
the
fix-oauth-quota-size
branch
from
e3f7d2d to
0890d01
Compare
|
Done. |
| @@ -207,7 +207,7 @@ | |||
| "oauth_storage_quota_claim": "Storage quota claim", | |||
| "oauth_storage_quota_claim_description": "Automatically set the user's storage quota to the value of this claim.", | |||
| "oauth_storage_quota_default": "Default storage quota (GiB)", | |||
| "oauth_storage_quota_default_description": "Quota in GiB to be used when no claim is provided (Enter 0 for unlimited quota).", | |||
| "oauth_storage_quota_default_description": "Quota in GiB to be used when no claim is provided.", | |||
There was a problem hiding this comment.
You should create a new key for this, since otherwise this won't show up as "untranslated" in other languages.
| @@ -253,7 +253,7 @@ export const defaults = Object.freeze<SystemConfig>({ | |||
| buttonText: 'Login with OAuth', | |||
| clientId: '', | |||
| clientSecret: '', | |||
| defaultStorageQuota: 0, | |||
| defaultStorageQuota: undefined, | |||
There was a problem hiding this comment.
Semantically I would probably prefer null here instead of undefined, since from my perspective we explicitly want to say "should be unlimited" and not "we don't define the value because we don't care about it". Would be interested to hear @jrasm91 thoughts on this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18504.