Skip to content

[6.0] Create a class alias for the CMS input class #43209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 4, 2024

Summary of Changes

Followup for #42890 which adds a class alias for the CMS input class.

Testing Instructions

Add the following code to the file /components/com_content/src/View/Featured/HtmlView.php inside the diplsay function around line 120:

new \Joomla\CMS\Input\Input();

Actual result BEFORE applying this Pull Request

Class not found error.

Expected result AFTER applying this Pull Request

Page loads.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo requested a review from Hackwar April 4, 2024 09:39
@laoneo laoneo added this to the Joomla! 6.0.0 milestone Apr 4, 2024
@HLeithner HLeithner added bug b/c break This item changes the behavior in an incompatible why. HEADS UP labels Apr 24, 2024
@HLeithner HLeithner changed the title Create a class alias for the CMS input class [6.0] Create a class alias for the CMS input class Apr 24, 2024
@laoneo laoneo removed the b/c break This item changes the behavior in an incompatible why. HEADS UP label Aug 14, 2024
@Bodge-IT
Copy link
Contributor

Bodge-IT commented Dec 7, 2024

I have tested this item ✅ successfully on 932116d

Tested and passed as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43209.

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on 932116d

The alias class mops up issues from [6.0] Removing CMS Input package #42890 by adding a class alias and testing showed the break and the fix


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43209.

@Bodge-IT Bodge-IT merged commit 02e1ed6 into joomla:6.0-dev Dec 7, 2024
4 checks passed
@laoneo laoneo deleted the input/alias branch December 7, 2024 14:05
@Bodge-IT
Copy link
Contributor

Bodge-IT commented Dec 7, 2024

Thanks @laoneo

HLeithner added a commit to HLeithner/joomla-cms that referenced this pull request Apr 16, 2025
HLeithner added a commit that referenced this pull request May 14, 2025
* Create backward compatibility 6 plugin
* Moved relevant code from old compat plugin and removed it

considered changes from prs:
#44926
#44240
#44638
#44700
#43209
#43958
#42884

* Add new plugin on install and uninstall old plugin
* Remove compat media folder, add compat6 removed.asset.json
* Fix cs exceptions
* Update ExtensionHelper
* Rename Compat.php to Compat6.php
* Disable compat6 plugin for system tests
* Restore class aliases from compat 5 plugin
* Relocate files from #44925

---------

Co-authored-by: Richard Fath <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
softforge pushed a commit that referenced this pull request May 25, 2025
* Create backward compatibility 6 plugin

* Moved relevant code from old compat plugin and removed it

considered changes from prs:
#44926
#44240
#44638
#44700
#43209
#43958
#42884

* Add new plugin on install and uninstall old plugin

* Remove compat media folder, add compat6 removed.asset.json

* Fix cs exceptions

* Update ExtensionHelper

* Rename Compat.php to Compat6.php

* Disable compat6 plugin for system tests

* Update administrator/language/en-GB/plg_behaviour_compat6.ini

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/language/en-GB/plg_behaviour_compat6.ini

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/src/Extension/Compat6.php

* Restore class aliases from compat 5 plugin

* Relocate files from #44925

* Apply language string improvement from review suggestion

Co-authored-by: Brian Teeman <[email protected]>

* Update plugins/behaviour/compat6/src/Extension/Compat6.php

Co-authored-by: Allon Moritz <[email protected]>

* Update plugins/behaviour/compat6/compat6.xml

Co-authored-by: Allon Moritz <[email protected]>

* Update installation/sql/mysql/base.sql

Co-authored-by: Richard Fath <[email protected]>

* Update installation/sql/postgresql/base.sql

Co-authored-by: Richard Fath <[email protected]>

* Fix wrong folder in uninstallation of compat (5) plugin.

---------

Co-authored-by: Richard Fath <[email protected]>
Co-authored-by: Richard Fath <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Benjamin Trenkle <[email protected]>
Co-authored-by: Allon Moritz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants