[6.0] Move the JPATH_PLATFORM constant to the compat plugin #44638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
added
the
b/c break
HLeithner
approved these changes
Jan 15, 2025
|
I have tested this item ✅ successfully on b7edaa5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638. |
|
I have tested this item 🔴 unsuccessfully on 95b56ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638. |
|
@Bodge-IT This has been fixed in PatchTester pending a new release. joomla-extensions/patchtester@07c2890 |
proof that we're not ready for this pointless change |
|
I have tested this item ✅ successfully on 95b56ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638. |
|
I have tested this item ✅ successfully on ecc5f35 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638. |
|
I'v moved the constant to the compat plugin. @Bodge-IT can you test the patch tester with the old code if it still works? |
|
I have tested this item ✅ successfully on d30e272 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638. |
laoneo
changed the title
HLeithner
added a commit
to HLeithner/joomla-cms
that referenced
this pull request
Apr 16, 2025
considered changes from prs: joomla#44926 joomla#44240 joomla#44638 joomla#44700 joomla#43209 joomla#43958 joomla#42884
HLeithner
added a commit
that referenced
this pull request
May 14, 2025
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Restore class aliases from compat 5 plugin * Relocate files from #44925 --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
softforge
pushed a commit
that referenced
this pull request
May 25, 2025
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/src/Extension/Compat6.php * Restore class aliases from compat 5 plugin * Relocate files from #44925 * Apply language string improvement from review suggestion Co-authored-by: Brian Teeman <[email protected]> * Update plugins/behaviour/compat6/src/Extension/Compat6.php Co-authored-by: Allon Moritz <[email protected]> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Allon Moritz <[email protected]> * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <[email protected]> * Fix wrong folder in uninstallation of compat (5) plugin. --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Benjamin Trenkle <[email protected]> Co-authored-by: Allon Moritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
JPATH_PLATFORMis not used anymore in the core. This pr moves the definition of it to the compatibility plugin. Extensions should check if_JEXECexists instead.Code review.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Move the JPATH_PLATFORM constant to the compat plugin Manual#348
No documentation changes for manual.joomla.org needed