-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
src: remove node.h APIs to make callback without an async context #58471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7+ years is likely a long enough deprecation cycle ;-)
This needs to update the corresponding entries in deprecations.md also. Deprecation code DEP0097 I believe. |
DEP0097 is a runtime warning and is still possible with the alternative API: node/test/addons/make-callback-domain-warning/binding.cc Lines 22 to 23 in a430ef5
domain . Or it can be deprecated in a separate PR, as it changes runtime warning -- while this PR is a fully build time deprecation.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58471 +/- ##
==========================================
- Coverage 90.22% 90.20% -0.02%
==========================================
Files 635 635
Lines 187313 187295 -18
Branches 36778 36782 +4
==========================================
- Hits 169003 168953 -50
- Misses 11080 11126 +46
+ Partials 7230 7216 -14
🚀 New features to boost your workflow:
|
I think this one you'll want to run CITGM for. This is probably still a fairly popular thing to use in extant Node.js addons. |
These APIs have been deprecated in #18632.
Given the parameter
async_context
is essential for stable APIAsyncLocalStorage
, it'd be better to remove them now.