Skip to content

CM-423: Improves e2e test for istio-csr controller to read from resource status #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

PillaiManish
Copy link
Contributor

@PillaiManish PillaiManish commented Feb 27, 2025

Refactor the e2e test case for istio-csr controller

  • parse the IstioCSR object using an unstructured converter, read resource status fields
  • move the grpcurl Job into a testdata file, apply with dynamic_resource_loader and config template values

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2025
@openshift-ci openshift-ci bot requested review from swghosh and TrilokGeer February 27, 2025 11:38
@swghosh
Copy link
Member

swghosh commented Feb 27, 2025

/retitle CM-423: Improves e2e test for istio-csr controller to read from IstioCSR status

@openshift-ci openshift-ci bot changed the title CM-423: Adds e2e test for istio-csr controller with grpc CreateCertificate call CM-423: Improves e2e test for istio-csr controller to read from IstioCSR status Feb 27, 2025
@swghosh
Copy link
Member

swghosh commented Feb 28, 2025

/label px-approved
/label docs-approved
No user facing changes are being introduced.

/cc @lunarwhite

@openshift-ci openshift-ci bot requested a review from lunarwhite February 28, 2025 09:06
@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Feb 28, 2025
@swghosh
Copy link
Member

swghosh commented Feb 28, 2025

/retitle Improves e2e test for istio-csr controller to read from resource status

@PillaiManish Please update the PR description.

@openshift-ci openshift-ci bot changed the title CM-423: Improves e2e test for istio-csr controller to read from IstioCSR status Improves e2e test for istio-csr controller to read from resource status Feb 28, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2025
@openshift-ci-robot
Copy link

@PillaiManish: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member

swghosh commented Feb 28, 2025

/retitle CM-423: Improves e2e test for istio-csr controller to read from resource status

@openshift-ci openshift-ci bot changed the title Improves e2e test for istio-csr controller to read from resource status CM-423: Improves e2e test for istio-csr controller to read from resource status Feb 28, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2025

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2025

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

The PR improves the e2e test scenarios for the new istio-csr controller.

  • Replaces the grpcurl job with the loader file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PillaiManish PillaiManish force-pushed the master branch 3 times, most recently from 2a46953 to 5637c78 Compare March 3, 2025 14:08
@swghosh
Copy link
Member

swghosh commented Mar 3, 2025

/retest
due to openshift/release#60386

@swghosh
Copy link
Member

swghosh commented Mar 3, 2025

This PR should auto-run the e2e-operator-tech-preview job,
once openshift/release#62285 sets in.

PS: the current run for the e2e-operator job excludes ginkgo test cases with Label("TechPreview").

@swghosh
Copy link
Member

swghosh commented Mar 3, 2025

/retest

@PillaiManish
Copy link
Contributor Author

/reopen

@PillaiManish PillaiManish reopened this Mar 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

The PR improves the e2e test scenarios for the new istio-csr controller.

  • Replaces the grpcurl job with the loader file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@PillaiManish: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@PillaiManish: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

Refactor the e2e test case for istio-csr controller

  • parse the IstioCSR object using an unstructured converter, read resource status fields
  • move the grpcurl Job into a testdata file, apply with dynamic_resource_loader and config template values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@swghosh swghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @lunarwhite
PTAL, for qe-approved label.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PillaiManish, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2025
Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

Refactor the e2e test case for istio-csr controller

  • parse the IstioCSR object using an unstructured converter, read resource status fields
  • move the grpcurl Job into a testdata file, apply with dynamic_resource_loader and config template values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ac9cc76 into openshift:master Mar 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants