Skip to content

CM-424: [o/cert-manager-operator] moved e2e test cases for TechPreview features #60386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Jan 7, 2025

Adds an optional e2e test job for o/cert-manager-operator,
test cases are filtered by the Ginkgo TechPreview label filter.

With this change the tech-preview e2e(s) will only be triggered when certain files which affect the TP features are changed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2025

@swghosh: This pull request references CM-424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

adds an optional e2e test job for cert-manager-operator, assumes test cases are filtered by the Ginkgo TechPreview label filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@swghosh swghosh force-pushed the cm-operator-tech-preview-e2e branch from 9d16b8b to b13c5b6 Compare January 7, 2025 14:34
@hector-vido
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2025
@swghosh swghosh marked this pull request as ready for review February 27, 2025 11:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025
@openshift-ci openshift-ci bot requested review from deads2k and TrilokGeer February 27, 2025 12:00
@swghosh swghosh force-pushed the cm-operator-tech-preview-e2e branch from b13c5b6 to 27e87c0 Compare February 27, 2025 15:45
@swghosh swghosh changed the title CM-424: [o/cert-manager-operator] optional test: e2e-operator-tech-preview CM-424: [o/cert-manager-operator] moved e2e test cases for TechPreview features Feb 27, 2025
@swghosh
Copy link
Member Author

swghosh commented Feb 27, 2025

/cc @bharath-b-rh
should resolve the failures in openshift/cert-manager-operator#229

@openshift-ci openshift-ci bot requested a review from bharath-b-rh February 27, 2025 15:49
@bharath-b-rh
Copy link
Contributor

/lgtm
except for the suggestion made by ordered-prow-config to change the cluster to build09.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2025

@swghosh: This pull request references CM-424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "cert-manager-1.15" instead.

In response to this:

Adds an optional e2e test job for o/cert-manager-operator,
test cases are filtered by the Ginkgo TechPreview label filter.

With this change the tech-preview e2e(s) will only be triggered when certain files which affect the TP features are changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh swghosh force-pushed the cm-operator-tech-preview-e2e branch from 27e87c0 to 9fb832b Compare February 28, 2025 12:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@swghosh
Copy link
Member Author

swghosh commented Feb 28, 2025

also, cc: @PillaiManish

@swghosh
Copy link
Member Author

swghosh commented Feb 28, 2025

except for the suggestion made by ordered-prow-config to change the cluster to build09.

@bharath-b-rh not sure what's causing the ordered prow config issue, I have re-run make jobs a bunch of times. Giving it another shot to see if resolved.

Meanwhile,
/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@swghosh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@swghosh swghosh force-pushed the cm-operator-tech-preview-e2e branch 2 times, most recently from d88a182 to e7ff3e2 Compare March 3, 2025 06:25
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2025
@swghosh swghosh force-pushed the cm-operator-tech-preview-e2e branch from e7ff3e2 to 4a460c5 Compare March 3, 2025 06:35
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@swghosh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cert-manager-operator-cert-manager-1.15-e2e-operator-tech-preview openshift/cert-manager-operator presubmit Presubmit changed
pull-ci-openshift-cert-manager-operator-master-e2e-operator-tech-preview openshift/cert-manager-operator presubmit Presubmit changed
pull-ci-openshift-cert-manager-operator-cert-manager-1.15-e2e-operator openshift/cert-manager-operator presubmit Ci-operator config changed
pull-ci-openshift-cert-manager-operator-master-e2e-operator openshift/cert-manager-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@swghosh
Copy link
Member Author

swghosh commented Mar 3, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@swghosh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@swghosh
Copy link
Member Author

swghosh commented Mar 3, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@swghosh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2025
@bharath-b-rh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants