Skip to content

[release-4.16] OCPBUGS-55807: update resolv.conf every time on bootstrap node #9694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] OCPBUGS-55807: update resolv.conf every time on bootstrap node #9694

wants to merge 2 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9504

/assign mandre

@yatanaka-1007
OCPBUGS-32792: update resolv.conf every tiem on bootstrap
8ac492c 
Currently, /etc/resolv.conf on bootstrap node is updated only once.
Because of this, /etc/resolv.conf may be incorrect due to timing
issues. By this change, /etc/resolv.conf is updtaed at all "up",
"dhcp4-update", "dhcp6-update" events.
@yatanaka-1007
OCPBUGS-32792: update resolv.conf every tiem on bootstrap
8790d5e 
Currently, /etc/resolv.conf on bootstrap node is updated only once.
Because of this, /etc/resolv.conf may be incorrect due to timing
issues. By this change, /etc/resolv.conf is updtaed at all "up",
"dhcp4-update", "dhcp6-update", "dns-change" events.

"dns-change" event is supposed to be enough if it works, but
"dns-change" is a new function[1] of NetworkManager. Other events,
"up", "dhcp4-update" and "dhcp6-update", are kept for environments
where "dns-change" doesn't works.

[1] NetworkManager starting from 1.42.2-12.el9_2 and
1.36.0-17.el8_6 adds a new event `dns-change` which is fired
whenever a change to the DNS configuration happens.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-51116 has been cloned as Jira Issue OCPBUGS-55807. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-55807: update resolv.conf every time on bootstrap node

In response to this:

This is an automated cherry-pick of #9504

/assign mandre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-51116: update resolv.conf every time on bootstrap node [release-4.16] OCPBUGS-55807: update resolv.conf every time on bootstrap node May 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 7, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-55807, which is invalid:

  • expected dependent Jira Issue OCPBUGS-51116 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9504

/assign mandre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dtantsur and mandre May 7, 2025 05:52
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mandre and additionally assign dtantsur, eslutsky, rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 8790d5e link false /test e2e-openstack-proxy
ci/prow/okd-scos-e2e-vsphere-ovn 8790d5e link false /test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur Awaiting requested review from dtantsur

@mandre mandre Awaiting requested review from mandre

Assignees

@mandre mandre

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @mandre @yatanaka-1007