Skip to content

[release-4.16] OCPBUGS-55807: update resolv.conf every time on bootstrap node #9694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
IFACE=$1
STATUS=$2
case "$STATUS" in
up|dhcp4-change|dhcp6-change)
up|dhcp4-change|dhcp6-change|dns-change)
logger -s "NM local-dns-prepender triggered by ${1} ${2}."

# In DHCP connections, the resolv.conf content may be late, thus we wait for nameservers
Expand Down Expand Up @@ -33,14 +33,14 @@ EOF
fi
fi
else
logger -s "NM local-dns-prepender: Checking if local DNS IP is the first entry in resolv.conf"
if grep nameserver /etc/resolv.conf | head -n 1 | grep -q "$DNS_IP" ; then
logger -s "NM local-dns-prepender: local DNS IP already is the first entry in resolv.conf"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
if cmp -s /etc/resolv.tmp /etc/resolv.conf; then
logger -s "NM local-dns-prepender: /etc/resolv.conf is already up to date"
rm -f /etc/resolv.tmp
exit 0
else
logger -s "NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver $DNS_IP'"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
logger -s "NM local-dns-prepender: overwriting /etc/resolv.conf to add local DNS IP and DNS servers obtained by DHCP"
mv -f /etc/resolv.tmp /etc/resolv.conf
fi
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
IFACE=$1
STATUS=$2
case "$STATUS" in
up|dhcp4-change|dhcp6-change)
up|dhcp4-change|dhcp6-change|dns-change)
logger -s "NM local-dns-prepender triggered by ${1} ${2}."

# In DHCP connections, the resolv.conf content may be late, thus we wait for nameservers
Expand Down Expand Up @@ -31,14 +31,14 @@ EOF
fi
fi
else
logger -s "NM local-dns-prepender: Checking if local DNS IP is the first entry in resolv.conf"
if grep nameserver /etc/resolv.conf | head -n 1 | grep -q "$DNS_IP" ; then
logger -s "NM local-dns-prepender: local DNS IP already is the first entry in resolv.conf"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
if cmp -s /etc/resolv.tmp /etc/resolv.conf; then
logger -s "NM local-dns-prepender: /etc/resolv.conf is already up to date"
rm -f /etc/resolv.tmp
exit 0
else
logger -s "NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver $DNS_IP'"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
logger -s "NM local-dns-prepender: overwriting /etc/resolv.conf to add local DNS IP and DNS servers obtained by DHCP"
mv -f /etc/resolv.tmp /etc/resolv.conf
fi
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
IFACE=$1
STATUS=$2
case "$STATUS" in
up|dhcp4-change|dhcp6-change)
up|dhcp4-change|dhcp6-change|dns-change)
logger -s "NM local-dns-prepender triggered by ${1} ${2}."

# In DHCP connections, the resolv.conf content may be late, thus we wait for nameservers
Expand Down Expand Up @@ -31,14 +31,14 @@ EOF
fi
fi
else
logger -s "NM local-dns-prepender: Checking if local DNS IP is the first entry in resolv.conf"
if grep nameserver /etc/resolv.conf | head -n 1 | grep -q "$DNS_IP" ; then
logger -s "NM local-dns-prepender: local DNS IP already is the first entry in resolv.conf"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
if cmp -s /etc/resolv.tmp /etc/resolv.conf; then
logger -s "NM local-dns-prepender: /etc/resolv.conf is already up to date"
rm -f /etc/resolv.tmp
exit 0
else
logger -s "NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver $DNS_IP'"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
logger -s "NM local-dns-prepender: overwriting /etc/resolv.conf to add local DNS IP and DNS servers obtained by DHCP"
mv -f /etc/resolv.tmp /etc/resolv.conf
fi
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
IFACE=$1
STATUS=$2
case "$STATUS" in
up|dhcp4-change|dhcp6-change)
up|dhcp4-change|dhcp6-change|dns-change)
logger -s "NM local-dns-prepender triggered by ${1} ${2}."

# In DHCP connections, the resolv.conf content may be late, thus we wait for nameservers
Expand Down Expand Up @@ -31,14 +31,14 @@ EOF
fi
fi
else
logger -s "NM local-dns-prepender: Checking if local DNS IP is the first entry in resolv.conf"
if grep nameserver /etc/resolv.conf | head -n 1 | grep -q "$DNS_IP" ; then
logger -s "NM local-dns-prepender: local DNS IP already is the first entry in resolv.conf"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
if cmp -s /etc/resolv.tmp /etc/resolv.conf; then
logger -s "NM local-dns-prepender: /etc/resolv.conf is already up to date"
rm -f /etc/resolv.tmp
exit 0
else
logger -s "NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver $DNS_IP'"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
logger -s "NM local-dns-prepender: overwriting /etc/resolv.conf to add local DNS IP and DNS servers obtained by DHCP"
mv -f /etc/resolv.tmp /etc/resolv.conf
fi
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
IFACE=$1
STATUS=$2
case "$STATUS" in
up|dhcp4-change|dhcp6-change)
up|dhcp4-change|dhcp6-change|dns-change)
{{if .PlatformData.VSphere.UserProvidedVIPs}}
logger -s "NM local-dns-prepender triggered by ${1} ${2}."
DNS_IP="127.0.0.1"
Expand Down Expand Up @@ -33,14 +33,14 @@ EOF
fi
fi
else
logger -s "NM local-dns-prepender: Checking if local DNS IP is the first entry in resolv.conf"
if grep nameserver /etc/resolv.conf | head -n 1 | grep -q "$DNS_IP" ; then
logger -s "NM local-dns-prepender: local DNS IP already is the first entry in resolv.conf"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
if cmp -s /etc/resolv.tmp /etc/resolv.conf; then
logger -s "NM local-dns-prepender: /etc/resolv.conf is already up to date"
rm -f /etc/resolv.tmp
exit 0
else
logger -s "NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver $DNS_IP'"
cp -f /var/run/NetworkManager/resolv.conf /etc/resolv.tmp
sed -i "/^# Generated by.*$/a nameserver $DNS_IP" /etc/resolv.tmp
logger -s "NM local-dns-prepender: overwriting /etc/resolv.conf to add local DNS IP and DNS servers obtained by DHCP"
mv -f /etc/resolv.tmp /etc/resolv.conf
fi
fi
Expand Down