Skip to content

Use CRD introspection flag to enable tool calling #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onmete
Copy link
Contributor

@onmete onmete commented May 19, 2025

Description

Removing workaround we had till the operator changes about introspection and mcp defaults.

@openshift-ci openshift-ci bot requested review from joshuawilson and xrajesh May 19, 2025 07:59
Copy link

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete onmete force-pushed the instrospection-through-crd branch from 2008235 to cc5fd0a Compare May 20, 2025 17:32
@onmete
Copy link
Contributor Author

onmete commented May 21, 2025

/retest

3 similar comments
@onmete
Copy link
Contributor Author

onmete commented May 22, 2025

/retest

@onmete
Copy link
Contributor Author

onmete commented May 22, 2025

/retest

@onmete
Copy link
Contributor Author

onmete commented May 22, 2025

/retest

@onmete onmete force-pushed the instrospection-through-crd branch from cc5fd0a to be6ceb7 Compare May 22, 2025 15:06
@onmete
Copy link
Contributor Author

onmete commented May 22, 2025

/retest

1 similar comment
@onmete
Copy link
Contributor Author

onmete commented May 26, 2025

/retest

@onmete
Copy link
Contributor Author

onmete commented May 26, 2025

/test 4.18-e2e-ols-cluster

Copy link

openshift-ci bot commented May 26, 2025

@onmete: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-e2e-ols-cluster be6ceb7 link true /test 4.18-e2e-ols-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@raptorsun
Copy link
Contributor

raptorsun commented May 27, 2025

there is 500 error from server side, when retrieving conversation, on both streaming and query endpoint.

2025-05-26 11:15:05,930 [ols.app.main:main.py:113] DEBUG: Request from 10.131.0.6:42172 Headers({"accept":"*/*", "accept-encoding":"gzip, deflate, zstd", "user-agent":"python-httpx/0.27.2", "authorization":"XXXXX", "content-length":"63", "content-type":"application/json", "host":"ols-openshift-lightspeed.apps.obs-ocp-4-18-fips-amd64-aws-us-east-1-dndzp.devobscluster.devcluster.openshift.com", "x-forwarded-host":"ols-openshift-lightspeed.apps.obs-ocp-4-18-fips-amd64-aws-us-east-1-dndzp.devobscluster.devcluster.openshift.com", "x-forwarded-port":"443", "x-forwarded-proto":"https", "forwarded":"for=54.164.67.119;host=ols-openshift-lightspeed.apps.obs-ocp-4-18-fips-amd64-aws-us-east-1-dndzp.devobscluster.devcluster.openshift.com;proto=https", "x-forwarded-for":"54.164.67.119"}), Body: {"conversation_id": "not-uuid", "query": "what is kubernetes?"}
2025-05-26 11:15:05,938 [ols.app.endpoints.ols:ols.py:283] INFO: Auth module: k8s
2025-05-26 11:15:05,938 [ols.app.endpoints.ols:ols.py:284] INFO: User ID: 4c0c5256-c794-483a-afe5-f99c0550460d
2025-05-26 11:15:05,938 [ols.app.endpoints.ols:ols.py:647] DEBUG: Redacting query for conversation not-uuid
2025-05-26 11:15:05,938 [ols.utils.redactor:redactor.py:40] DEBUG: Redacting conversation not-uuid
2025-05-26 11:15:05,938 [ols.utils.redactor:redactor.py:45] DEBUG: Replaced: 0 matched with filter: foo_filter
2025-05-26 11:15:05,938 [ols.utils.redactor:redactor.py:45] DEBUG: Replaced: 0 matched with filter: bar_filter
2025-05-26 11:15:05,938 [ols.utils.redactor:redactor.py:48] DEBUG: Redacted conversation not-uuid input: what is kubernetes?
2025-05-26 11:15:05,938 [ols.app.endpoints.ols:ols.py:302] INFO: Conversation ID: not-uuid Incoming request: what is kubernetes?
2025-05-26 11:15:05,939 [ols.src.cache.postgres_cache:postgres_cache.py:134] INFO: Connection to storage is ok
2025-05-26 11:15:05,939 [ols.app.endpoints.ols:ols.py:463] ERROR: Error retrieving previous user input for user 4c0c5256-c794-483a-afe5-f99c0550460d
2025-05-26 11:15:05,939 [ols.app.main:main.py:121] DEBUG: Response to 10.131.0.6:42172 Headers({"content-length":"106", "content-type":"application/json"})
INFO:     10.131.0.6:42172 - "POST /v1/query HTTP/1.1" 500 Internal Server Error
2025-05-26 11:15:05,940 [ols.app.main:main.py:127] DEBUG: Response to 10.131.0.6:42172 Body chunk: {"detail":{"response":"Error retrieving conversation history","cause":"Invalid conversation ID not-uuid"}}}

@onmete
Copy link
Contributor Author

onmete commented May 27, 2025

@raptorsun Yes, because of FileNotFoundError: [Errno 2] No such file or directory: 'python' for the mcp_server arg (instead of python3.11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants