Skip to content

OCPEDGE-1230: add metadata size field #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Sep 24, 2024

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024

@qJkee: This pull request references OCPEDGE-1230 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2024
@qJkee qJkee force-pushed the OCPEDGE-1230 branch 2 times, most recently from 8c2408a to 440a48c Compare October 10, 2024 04:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 39.39394% with 40 lines in your changes missing coverage. Please review.

Project coverage is 69.04%. Comparing base (ede5f97) to head (ae77860).

Files with missing lines Patch % Lines
api/v1alpha1/lvmcluster_webhook.go 27.58% 16 Missing and 5 partials ⚠️
internal/controllers/vgmanager/lvm/lvm.go 18.75% 13 Missing ⚠️
internal/controllers/vgmanager/controller.go 71.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   70.06%   69.04%   -1.03%     
==========================================
  Files          49       49              
  Lines        3351     3415      +64     
==========================================
+ Hits         2348     2358      +10     
- Misses        829      874      +45     
- Partials      174      183       +9     
Files with missing lines Coverage Δ
api/v1alpha1/lvmcluster_types.go 100.00% <ø> (ø)
internal/controllers/vgmanager/controller.go 71.72% <71.42%> (-0.09%) ⬇️
internal/controllers/vgmanager/lvm/lvm.go 93.56% <18.75%> (-5.53%) ⬇️
api/v1alpha1/lvmcluster_webhook.go 79.07% <27.58%> (-5.91%) ⬇️

... and 6 files with indirect coverage changes

this change introduces 2 new fields to lvms cluster
MetadataSizeCalculationPolicy and MetadataSize which
is used to control metadata size of thin pool
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@qJkee
Copy link
Contributor Author

qJkee commented Oct 11, 2024

/hold for QE pre merge testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@qJkee qJkee changed the title [WIP]OCPEDGE-1230: add metadata size field OCPEDGE-1230: add metadata size field Oct 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@qJkee
Copy link
Contributor Author

qJkee commented Oct 11, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3ddce5f into openshift:main Oct 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants