-
Notifications
You must be signed in to change notification settings - Fork 42
OCPEDGE-1230: add metadata size field #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@qJkee: This pull request references OCPEDGE-1230 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qJkee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8c2408a
to
440a48c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
- Coverage 70.06% 69.04% -1.03%
==========================================
Files 49 49
Lines 3351 3415 +64
==========================================
+ Hits 2348 2358 +10
- Misses 829 874 +45
- Partials 174 183 +9
|
this change introduces 2 new fields to lvms cluster MetadataSizeCalculationPolicy and MetadataSize which is used to control metadata size of thin pool
/lgtm |
/hold for QE pre merge testing |
/unhold |
@qJkee: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.