Removal of docker tests and related helper code #4521
Conversation
girishramnani
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
openshift-ci-robot
added
the
lgtm
|
@girishramnani: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -600,11 +600,6 @@ func validateContainerExecListDir(odoV1Watch OdoV1Watch, odoV2Watch OdoV2Watch, | |||
| dir := envs["ODO_S2I_SRC_BIN_PATH"] | |||
| stdOut = ocRunner.ExecListDir(podName, project, filepath.ToSlash(filepath.Join(dir, "src"))) | |||
| } | |||
| case "docker": | |||
There was a problem hiding this comment.
There are more occurrences in this file here https://github.com/openshift/odo/blob/master/tests/integration/devfile/utils/utils.go#L685-L690
What type of PR is this?
/kind code-refactoring
What does does this PR do / why we need it:
see $SUBJECT
Which issue(s) this PR fixes:
relates to #4500
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
All tests should pass