Skip to content

NO-JIRA: match external platform #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

Conversation

neisw
Copy link
Contributor

@neisw neisw commented May 21, 2025

Working through external jobs in openshift/release#64021
I don't believe these are contributing signal to CR currently but reviewed with @mtulio cases where platformSpec is external and platform aws, vshpere, etc. Decided on keeping the platform and using procedure to note the external type.

items:
- apiVersion: config.openshift.io/v1
  kind: Infrastructure
  metadata:
    creationTimestamp: "2025-05-20T16:02:15Z"
    generation: 1
    name: cluster
    resourceVersion: "500"
    uid: 8c6c3f21-3560-469c-b91c-8a408c4657e8
  spec:
    cloudConfig:
      name: ""
    platformSpec:
      external:
        platformName: aws
      type: External
  status:
    apiServerInternalURI: https://api-int.ci-op-sdp6rf1c-bed9e.xxxxxxxxxxxxxxxxxxxxxx:6443/
    apiServerURL: https://api.ci-op-sdp6rf1c-bed9e.xxxxxxxxxxxxxxxxxxxxxx:6443/
    controlPlaneTopology: HighlyAvailable
    cpuPartitioning: None
    etcdDiscoveryDomain: ""
    infrastructureName: ci-op-sdp6rf1c-bed9e-gsxmp
    infrastructureTopology: HighlyAvailable
    platform: External
    platformStatus:
      external:
        cloudControllerManager:
          state: External
      type: External
kind: List

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2025
@openshift-ci-robot
Copy link

@neisw: This pull request explicitly references no jira issue.

In response to this:

We should likely be setting external topology for jobs in openshift/release#64021

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and dgoodwin May 21, 2025 00:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@neisw neisw force-pushed the external branch 3 times, most recently from 29eb6bb to 3f8df94 Compare May 21, 2025 00:35
@neisw
Copy link
Contributor Author

neisw commented May 21, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2025
@mtulio
Copy link
Contributor

mtulio commented May 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2025
@neisw neisw changed the title NO-JIRA: match external topology NO-JIRA: match external platform May 22, 2025
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, neisw, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor Author

neisw commented May 28, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
Copy link
Contributor

openshift-ci bot commented May 28, 2025

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 272ffb0 into openshift:main May 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants