Skip to content

Release tracking #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Release tracking #1032

merged 1 commit into from
May 30, 2025

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented May 29, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Patch Changes

  • #1034 0d3a198 Thanks @rezrah! - Added new tokens for LogoSuite play/pause controls for improved visual contrast and granular customization

    + --brand-LogoSuite-color-control-rest
    + --brand-LogoSuite-color-control-hover

@primer/[email protected]

Patch Changes

  • #1030 4ee490d Thanks @rezrah! - Fixed SubdomainNavBar to preserve the original ordering of actions in JSX, allowing more flexibility in CTA placement.

    <SubdomainNavBar title="Subdomain">
      <SubdomainNavBar.Link />
      <SubdomainNavBar.SecondaryAction href="#">Secondary CTA</SubdomainNavBar.SecondaryAction>
      {/* Primary actions can now render at the end */}
      <SubdomainNavBar.PrimaryAction href="#">Primary CTA</SubdomainNavBar.PrimaryAction>
    </SubdomainNavBar>
  • #1031 094cdf4 Thanks @rezrah! - SubNav component now correctly forwards refs to the underlying element.

  • #1034 0d3a198 Thanks @rezrah! - Increased contrast on LogoSuite.Logobar play/pause button in marquee mode.

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 10:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version numbers and changelogs for multiple packages as part of the automated release process for the Primer Brand system. Key changes include:

  • Bumping version numbers from 0.54.1 to 0.54.2 in package.json files for various packages.
  • Adding corresponding 0.54.2 entries to the CHANGELOG.md files.
  • Removing the associated changeset file after release.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/repo-configs/package.json Updated version to 0.54.2
packages/repo-configs/CHANGELOG.md Added changelog entry for 0.54.2
packages/react/package.json Updated version to 0.54.2
packages/react/CHANGELOG.md Added detailed patch changelog including SubdomainNavBar fix
packages/fonts/package.json Updated version to 0.54.2
packages/fonts/CHANGELOG.md Added changelog entry for 0.54.2
packages/e2e/package.json Updated version to 0.54.2
packages/e2e/CHANGELOG.md Added changelog entry for 0.54.2
packages/design-tokens/package.json Updated version to 0.54.2
packages/design-tokens/CHANGELOG.md Added changelog entry for 0.54.2
apps/storybook/package.json Updated version to 0.54.2
apps/storybook/CHANGELOG.md Added changelog entry for 0.54.2
apps/next-docs/package.json Updated version and corresponding dependency versions
apps/next-docs/CHANGELOG.md Added changelog entry for 0.54.2
.changeset/chilled-nails-clap.md Removed changeset file as part of the release process

Copy link
Contributor

github-actions bot commented May 29, 2025

❗ Pre-merge checklist

Please ensure these items are checked before merging.

✅ Preliminary checks

  • All CI checks pass on this pull request
  • Docs and Storybook previews open in a browser

🔌 Integration smoke tests

Dotcom

  • Performed successful integration test with github/github, as a primary consumer of Primer Brand
    • Install RC: bin/npm install --save --save-exact @primer/react-brand@{RC_VERSION}
      Important: Verify that each workspace package has been updated correctly in their respective package.json files
    • Run development server
    • Manually verify release-specific bugfixes and/or features on the following pages:
      • /features/copilot
      • /features/copilot/tutorials
      • /features/preview
      • /enterprise
      • /enterprise/contact
      • /security/advanced-security
      • /education
      • /mobile
      • /about/diversity
      • /newsroom
      • /resources/articles
      • /resources/articles/software-development
      • /resources/articles/software-development/what-is-cloud-native
      • /resources/whitepapers
      • /resources/whitepapers/how-the-c-suite-can-lead-ai-innovation
      • /solutions
      • /solutions/use-case/
      • /solutions/use-case/devops
    • Manually compare production site to local instance for any non-release specific regressions

Subdomain sites

  • Performed successful integration test with githubuniverse.com, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production
  • Performed successful integration test with https://resources.github.com/, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production

Sandboxes

  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Cross-check (aka sanity test)

  • Release notes accurately describe the changes made
  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions or side-effects have not been introduced as a result of changes in this release.
    • If they have, determine severity of the issue and consider hotfixing

After tests

  • Add report summary of your findings, including any images. Use following template as a guide:

    #### Smoke test results
    
    - Feature 1 🟢 🟡 🔴 (choose one, depending on success levels)
    
      {insert screenshot}
    
    Release testing status: Ready to release 🟢 | Paused 🟡 🔴 (choose one and provide reason)

🚢 After merge

  • Issue release comms in primer brand Slack channel
  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Copy link
Contributor

github-actions bot commented May 29, 2025

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented May 29, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
Copy link
Collaborator

rezrah commented May 30, 2025

Smoke test results

  • Increased contrast on LogoSuite.Logobar play/pause button in marquee mode 🟢

    Update restores visual parity to controls in various dotcom pages, like Copilot.

    Before After

    Screenshot 2025-05-30 at 12 10 52

    Screenshot 2025-05-30 at 13 18 38

  • Fixed SubdomainNavBar to preserve the original ordering of actions in JSX 🟢

    Verified on subdomains and dotcom. Works as expected. Adequate test coverage also available in Primer Brand for this update.

    Example of reordered actions:

    Screenshot 2025-05-30 at 13 21 24

  • SubNav component now correctly forwards refs to the underlying element 🟢

    Ref forwarding works as expected, including SWP-teams anticipated use-case around height calculation (cc. @seangolob):

    Screenshot 2025-05-30 at 13 26 10

    Note: The height of the SubNav is reporting larger than what it should by default (124px vs 56px. This is because of a custom CSS class being applied to it, thereby increasing the vertical padding.

    Screenshot 2025-05-30 at 13 29 45

    Removing lp-SubNav padding should restore native height of 56px. The custom style should instead be applied to a wrapper / parent of the SubNav.

    Adequate test coverage is also available in Primer Brand for this update.

Release testing status: Ready to release 🟢

@rezrah rezrah merged commit fd1becc into main May 30, 2025
18 checks passed
@rezrah rezrah deleted the changeset-release/main branch May 30, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants