-
Notifications
You must be signed in to change notification settings - Fork 52
Increased contrast of LogoSuite.Logobar play/pause button background #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fde9162 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes+ --brand-LogoSuite-color-control-rest: var(--base-color-scale-gray-1); + --brand-LogoSuite-color-control-hover: var(--base-color-scale-gray-2); + --brand-LogoSuite-color-control-rest: #4d4e6a; + --brand-LogoSuite-color-control-hover: #5a5b7c; + --brand-LogoSuite-color-control-hover: var(--base-color-scale-gray-2); + --brand-LogoSuite-color-control-rest: var(--base-color-scale-gray-1); |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces dedicated design tokens to improve the contrast of the LogoSuite marquee play/pause button and updates the CSS to use them.
- Added new
control.rest
andcontrol.hover
tokens for LogoSuite in design-tokens. - Updated
LogoSuite.module.css
to use--brand-LogoSuite-color-control-...
instead of button-subtle tokens. - Created changesets to publish the patches in both
@primer/brand-primitives
and@primer/react-brand
.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
packages/react/src/LogoSuite/LogoSuite.module.css | Replaced background-color vars with new control tokens |
packages/design-tokens/src/tokens/functional/components/logosuite/colors.json | Added control.rest and control.hover entries |
.changeset/witty-dolls-sleep.md | Described new tokens for LogoSuite play/pause controls |
.changeset/mean-pants-hear.md | Described contrast update for LogoSuite in react-brand |
Comments suppressed due to low confidence (1)
packages/react/src/LogoSuite/LogoSuite.module.css:189
- The focus-visible state doesn’t use the new control token. Consider adding a dedicated
--brand-LogoSuite-color-control-focus
token (or fallback) and applying it here to ensure keyboard focus has sufficient contrast.
.LogoSuite__logobar-playPauseButton:focus-visible {
Summary
Resolves https://github.com/github/primer/issues/5240
Increases contrast of the play/pause button against animated logos in marquee mode. Logobar controls now have dedicated tokens, decoupling them from the Button styles they previously used.
Note: Color choices now are parity (or closest match) with custom styles applied in Dotcom. E.g. from the custom video controls:
🔗 Preview link
List of notable changes:
What should reviewers focus on?
Steps to test:
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: